Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model recompile on windows and MacOS #28

Merged
merged 5 commits into from
Dec 28, 2021

Conversation

Bandsberg
Copy link
Contributor

Changes recompile to 'save file event'.

Solves some of the issues related to #12, as the model recompiles and reloades on Win10 but only recompiles on MacOS.
The issue of reloading model on MacOS does not appear to be related monitoring of/watching for changes to model files.

@Bandsberg
Copy link
Contributor Author

Bandsberg commented Dec 27, 2021

Also added Debug settings for codeLLDB VSCode extension. Maybe that should either be removed or added to VScode as a suggested extension?

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Bandsberg, looks great! I also just tested this on my machine, and can confirm that it still works on Linux.

There's one problem: Two rebuilds are triggered for the same modification. The second rebuild barely takes any time though, so it's only a minor annoyance. And that it works on more platforms is more important anyway.

I'm going to merge this and will open a separate issue for the multiple-rebuilds problem.

@hannobraun hannobraun merged commit 591a5ac into hannobraun:main Dec 28, 2021
@hannobraun
Copy link
Owner

Also added Debug settings for codeLLDB VSCode extension. Maybe that should either be removed or added to VScode as a suggested extension?

Okay, as usual I forgot to reply to something.

I'm not using a debugger right now, but I'm fine with merging configuration that is used by regular contributors, as long as it's not too disruptive otherwise.

By "suggested extension", do you mean Recommended Extensions? I haven't used this feature before, so I'm not sure what to do here. Would that mean that every VS code user would get a pop-up about this extension, or something? If so, I don't think this is necessary.

@Bandsberg
Copy link
Contributor Author

By "suggested extension", do you mean Recommended Extensions? I haven't used this feature before, so I'm not sure what to do here. Would that mean that every VS code user would get a pop-up about this extension, or something? If so, I don't think this is necessary.

I do and yes there would be a pop-up. Roger that 😄

@Bandsberg Bandsberg deleted the model_reload_windows_osx branch December 28, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants