Add Approximation::for_face
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits come from an aborted attempt to support continuous faces in the approximation code, which would be required to fully address #97. As it turns out, the solution would require a lot of changes, more than I want to make right now. All that's left from that branch is the new
Approximation::for_face, which doesn't add a whole lot, but at least has some comments that could serve as useful guide posts for future extensions.As for the reasons I aborted my attempt to approximate continuous faces, I'll open an issue soon. That will require some explaining though, and I haven't found the time yet to write all of it down.