Clean up approximation code #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to use it in unit tests.
This is simpler and less error-prone that what was there previously.
This is simpler and less error-prone than what was there previously.
This addresses part of #240. This required a modification to the approximation test suite, which had some redundant checking code. I will follow this up with a cleanup in the next commit, to remove the redundancy.
It doesn't check very much any more, after the latest round of cleanups. What it does check, should be well-covered by the existing unit tests, so there's not much point in keeping it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a round of cleanups of the approximation code, which has been enabled by other recent cleanups (namely #193 and #244). I'm working on improvements to the approximation code that are necessary for #97, and these cleanups will make that a bit easier.