Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make small cleanups in validation code #2300

Merged
merged 2 commits into from
Mar 27, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unused code
  • Loading branch information
hannobraun committed Mar 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 003cfada4535ba505b54e87e076f68970743b70a
4 changes: 0 additions & 4 deletions crates/fj-core/src/validate/edge.rs
Original file line number Diff line number Diff line change
@@ -15,7 +15,3 @@ impl Validate for HalfEdge {
) {
}
}

/// [`HalfEdge`] validation failed
#[derive(Clone, Debug, thiserror::Error)]
pub enum EdgeValidationError {}
4 changes: 2 additions & 2 deletions crates/fj-core/src/validate/mod.rs
Original file line number Diff line number Diff line change
@@ -79,8 +79,8 @@ use crate::{
};

pub use self::{
edge::EdgeValidationError, shell::ShellValidationError,
sketch::SketchValidationError, solid::SolidValidationError,
shell::ShellValidationError, sketch::SketchValidationError,
solid::SolidValidationError,
};

/// Assert that some object has a validation error which matches a specific
7 changes: 1 addition & 6 deletions crates/fj-core/src/validation/error.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
use std::{convert::Infallible, fmt};

use crate::validate::{
EdgeValidationError, ShellValidationError, SketchValidationError,
SolidValidationError,
ShellValidationError, SketchValidationError, SolidValidationError,
};

use super::checks::{
@@ -25,10 +24,6 @@ pub enum ValidationError {
#[error(transparent)]
InteriorCycleHasInvalidWinding(#[from] InteriorCycleHasInvalidWinding),

/// `Edge` validation error
#[error("`Edge` validation error")]
Edge(#[from] EdgeValidationError),

/// `Shell` validation error
#[error("`Shell` validation error")]
Shell(#[from] ShellValidationError),