Fully integrate Curve
#1952
Merged
Fully integrate Curve
#1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GlobalEdge` no longer has any vertices.
I'm about to add another one here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curvewas added earlier in #1950, but it wasn't really used yet. The correct curves weren't added were they had to be, and there was no validation code to check that.This changes in this pull request. All code that needs to take
Curves into account has been updated to do so, as have the relevant validation tests.GlobalEdgestill exists, and both basically fulfill the same purpose. I intend to remove it in a follow-up pull request.This is a big step towards addressing #1937. What's still missing is to update the approximation code to use
Curveinstead ofGlobalEdge.