Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Region to an object #1883

Merged
merged 28 commits into from
Jun 13, 2023
Merged

Promote Region to an object #1883

merged 28 commits into from
Jun 13, 2023

Conversation

hannobraun
Copy link
Owner

As I'm working on restoring more example models (see #1868), I'm seeing the need for operations to be implemented on Region. Operations are only implemented for objects, and Region was not an object before this pull request.

This alone might not be reason enough to turn Region into an object (the operations API could also include non-objects), but I'm also planning some changes to how object identity is handled (no issue yet; will open one once I get the chance), and I see benefits to Region being an object under this new model. So given that, and to keep the operations API consistent, I decided to promote Region to an object.

This already includes some changes to the operations API, which were necessary to keep things working. Not making those changes and keeping UpdateFace as it was, caused borrow checker issues that aren't an issue by keeping things clean and introducing UpdateRegion, as I did in this pull request.

@hannobraun hannobraun enabled auto-merge June 13, 2023 11:40
@hannobraun hannobraun merged commit d899c4a into main Jun 13, 2023
@hannobraun hannobraun deleted the region branch June 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant