Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Sketches v2 #1828

Merged
merged 3 commits into from
May 16, 2023
Merged

Rework Sketches v2 #1828

merged 3 commits into from
May 16, 2023

Conversation

A-Walrus
Copy link
Contributor

@A-Walrus A-Walrus commented May 15, 2023

Version 2 of #1801, this version is rebased and much simpler. Not sure how to test that this is working with the new changes? Tests are passing, but other than that I don't know what to check...

) -> Self::Approximation {
self.faces().approx_with_cache(tolerance, cache)
todo!()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left this as a todo!() for now as I'm not aware that we need to approximate Sketches directly yet, we always first turn them into faces/shells and then approximate?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair enough. We can fill this in once required 👍

@A-Walrus A-Walrus marked this pull request as ready for review May 15, 2023 16:47
@A-Walrus A-Walrus requested a review from hannobraun as a code owner May 15, 2023 16:47
hannobraun
hannobraun previously approved these changes May 16, 2023
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @A-Walrus, looks great!

I found one typo and left a comment with a suggestion. I can probably apply that myself, after submitting this review.

Not sure how to test that this is working with the new changes? Tests are passing, but other than that I don't know what to check...

Yeah, sorry. We temporarily lost the example models, and the automated testing associated with them. I'll re-add those soon. For now, I'm happy to merge anything that compiles and looks reasonable.

) -> Self::Approximation {
self.faces().approx_with_cache(tolerance, cache)
todo!()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair enough. We can fill this in once required 👍

crates/fj-kernel/src/geometry/region.rs Outdated Show resolved Hide resolved
@hannobraun hannobraun enabled auto-merge May 16, 2023 08:28
@hannobraun hannobraun mentioned this pull request May 16, 2023
@hannobraun hannobraun merged commit 2d15ac0 into hannobraun:main May 16, 2023
@A-Walrus A-Walrus deleted the sketch_face_v2 branch September 25, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants