Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare HalfEdgeBuilder for HalfEdge/PartialHalfEdge unification #1662

Merged
merged 43 commits into from
Mar 9, 2023
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b2830a4
Make trait method more convenient to call
hannobraun Mar 9, 2023
37e1689
Update variable names
hannobraun Mar 9, 2023
b936c4f
Return curve from `HalfEdgeBuilder::update_as_arc`
hannobraun Mar 9, 2023
857adb2
Merge variables
hannobraun Mar 9, 2023
73b313c
Remove needless allocation
hannobraun Mar 9, 2023
72b6086
Consolidate redundant code
hannobraun Mar 9, 2023
889f4a5
Simplify `CycleBuilder::add_half_edge`
hannobraun Mar 9, 2023
2c0a7d4
Remove redundant return value
hannobraun Mar 9, 2023
3b84e73
Add `HalfEdgeBuilder::make_circle`
hannobraun Mar 9, 2023
0a68de0
Simplify `PartialHalfEdge` construction
hannobraun Mar 9, 2023
a4d10c2
Update variable name
hannobraun Mar 9, 2023
629bfde
Update variable name
hannobraun Mar 9, 2023
f957f5b
Prepare code for follow-on change
hannobraun Mar 9, 2023
4150187
Add `HalfEdgeBuilder::make_arc`
hannobraun Mar 9, 2023
fcc3412
Update variable name
hannobraun Mar 9, 2023
632f0b4
Refactor
hannobraun Mar 9, 2023
7ceb38f
Move code to prepare for follow-on change
hannobraun Mar 9, 2023
6bb5b6a
Make variable name more accurate
hannobraun Mar 9, 2023
b66c957
Refactor code to simplify it
hannobraun Mar 9, 2023
678dfeb
Remove comment
hannobraun Mar 9, 2023
8c609f8
Update variable names
hannobraun Mar 9, 2023
2a80634
Refactor to prepare for follow-on change
hannobraun Mar 9, 2023
4e89719
Refactor to prepare for follow-on change
hannobraun Mar 9, 2023
460c7d9
Prepare builder method for change to constructor
hannobraun Mar 9, 2023
b60cfa6
Prepare builder method for change to constructor
hannobraun Mar 9, 2023
2ab9121
Simplify trait method arguments
hannobraun Mar 9, 2023
4fa5bc9
Merge variables
hannobraun Mar 9, 2023
af90851
Simplify builder method
hannobraun Mar 9, 2023
5e06c95
Update variable name
hannobraun Mar 9, 2023
037718a
Refactor code to simplify it
hannobraun Mar 9, 2023
fdcde32
Refactor code to simplify it
hannobraun Mar 9, 2023
9b1d0e1
Refactor code to simplify it
hannobraun Mar 9, 2023
5250203
Add `ObjectArguments::map_with_next`
hannobraun Mar 9, 2023
68d7e45
Make trait method more convenient to call
hannobraun Mar 9, 2023
ebfa61c
Simplify builder method
hannobraun Mar 9, 2023
b019e82
Add `HalfEdgeBuilder::make_line_segment`
hannobraun Mar 9, 2023
7f72057
Update variable name
hannobraun Mar 9, 2023
428ab91
Simplify variable name
hannobraun Mar 9, 2023
b421863
Refactor code to simplify it
hannobraun Mar 9, 2023
0a0f971
Make builder method more flexible
hannobraun Mar 9, 2023
f2d6eb9
Make builder method more flexible
hannobraun Mar 9, 2023
356f7d1
Update doc comments
hannobraun Mar 9, 2023
6c2e50d
Add `HalfEdgeBuilder::make_half_edge`
hannobraun Mar 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make trait method more convenient to call
hannobraun committed Mar 9, 2023
commit b2830a4afe4b7cc71a3b6e87e12ac860b34bfc20
8 changes: 4 additions & 4 deletions crates/fj-kernel/src/builder/edge.rs
Original file line number Diff line number Diff line change
@@ -19,8 +19,8 @@ pub trait HalfEdgeBuilder {
/// Panics if the given angle is not within the range (-2pi, 2pi) radians.
fn update_as_arc(
&mut self,
start: Point<2>,
end: Point<2>,
start: impl Into<Point<2>>,
end: impl Into<Point<2>>,
angle_rad: impl Into<Scalar>,
);

@@ -54,8 +54,8 @@ impl HalfEdgeBuilder for PartialHalfEdge {

fn update_as_arc(
&mut self,
start: Point<2>,
end: Point<2>,
start: impl Into<Point<2>>,
end: impl Into<Point<2>>,
angle_rad: impl Into<Scalar>,
) {
let angle_rad = angle_rad.into();