Define circle radius using 2D vector #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3D definition is kind of wrong. I think all code currently assumes
that circles are in the x-y place[1]. Even if that weren't the case, a
single 3D vector would not be enough to define the plane of the circle.
I think the best solution for now is to make this change, and
investigate how the circle representation needs to be improved later.
[1] This would mean that circles and shapes based on circles can't
currently be rotated. There's no issue to track this, so if this is
true, one should be opened. I've added investigating this to my task
list.