Improve host model loading (on-demand background thread) #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event loop is no longer blocked by model processing. Status updates are initiated with `EventLoopProxy` from a background thread. Separate status updates occur for 'initial load' and 'change detected' of a model.
This commit also removes `Evaluator` and replaces it with free functions.
hannobraun
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Thank you for this pull request, @zthompson47!
I think this looks great too. I'd be happy to merge it, in principle, but I prefer the approach of #1476, for the reasons we talked about in #1431.
So unless you disagree, I suggest we close this and move ahead with #1476. What do you think?
|
I agree that #1476 is a nicer approach - I'll close this one and proceed with the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1431 and fixes #1327 by reworking the evaluator thread. The creation of a new thread sends a
StartWatchingmessage to the event loop viawinit::event_loop::EventLoopProxy. A separateChangeDetectedmessage is sent when a model is edited. TheShapeProcessoris sent to the background thread so all processing happens outside of the event loop, preventing blocking.