Fix known surface duplication issues #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vertex transform code transformed the surface form directly, instead of converting it into a partial object first. This gave the higher-level transform code no opportunity to override the surface later, making it impossible not to create duplicate surfaces.
|
CI is failing because I overlooked another problem that I accidentally introduced. I'm looking into it. |
If there already was a `Some(PartialSurfaceVertex)`, it would just leave it as is, instead of overriding its surface and other data. This would result in duplicate surfaces being created when transforming a half-edge.
|
Figured it out. These damn bugs can be so subtle... good thing we have validation code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the previous work done in #1168, #1170, #1172, and other pull requests, fixing all other known surface duplication issues and updating any surface-related validation code to use surface identity instead of surface equality, making this validation code much stricter and preventing possible bugs. This was made possible by advancements in #1021.
See the documentation added in this commit for a detailed explanation:
https://github.com/hannobraun/Fornjot/blob/87612f1e04be115528ba7dc929fef5bc442348e7/crates/fj-kernel/src/objects/mod.rs#L8-L71