Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Edge to HalfEdge #1064

Merged
merged 38 commits into from
Sep 8, 2022
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2f0a051
Remove redundant information from doc comment
hannobraun Sep 8, 2022
9111748
Remove obsolete implementation note
hannobraun Sep 8, 2022
92de5aa
Rename `Edge` to `HalfEdge`
hannobraun Sep 8, 2022
864d178
Update argument name
hannobraun Sep 8, 2022
d5d7021
Update variable names
hannobraun Sep 8, 2022
433e7c3
Restore alphabetic order of trait implementations
hannobraun Sep 8, 2022
40af85b
Update variable name
hannobraun Sep 8, 2022
4bc4041
Update variable name
hannobraun Sep 8, 2022
57a82ad
Update struct name
hannobraun Sep 8, 2022
16ab99f
Update trait method name
hannobraun Sep 8, 2022
b68e2cc
Update doc comment
hannobraun Sep 8, 2022
c92b4ca
Restore alphabetic ordering of trait methods
hannobraun Sep 8, 2022
258fc0e
Restore alphabetic ordering of trait impls
hannobraun Sep 8, 2022
4db8443
Update test name
hannobraun Sep 8, 2022
c9a481f
Restore alphabetic ordering of tests
hannobraun Sep 8, 2022
14bb370
Restore alphabetic ordering of test assertions
hannobraun Sep 8, 2022
21aa19e
Update struct field name
hannobraun Sep 8, 2022
13e1217
Update variable name
hannobraun Sep 8, 2022
3d8c999
Update argument name
hannobraun Sep 8, 2022
e740f13
Update variable name
hannobraun Sep 8, 2022
419b40b
Update method name
hannobraun Sep 8, 2022
2a71754
Update variable name
hannobraun Sep 8, 2022
226e830
Update variable name
hannobraun Sep 8, 2022
e636eea
Update struct field name
hannobraun Sep 8, 2022
b3c7019
Simplify variable name
hannobraun Sep 8, 2022
6a47847
Update struct name
hannobraun Sep 8, 2022
4784e46
Update method name
hannobraun Sep 8, 2022
1e520a0
Update doc comments
hannobraun Sep 8, 2022
4119331
Update variable name
hannobraun Sep 8, 2022
82ff01c
Simplify code
hannobraun Sep 8, 2022
e8d6519
Update variable name
hannobraun Sep 8, 2022
54ea129
Update variable name
hannobraun Sep 8, 2022
44fa9dc
Update variable name
hannobraun Sep 8, 2022
00b9907
Update argument name
hannobraun Sep 8, 2022
ce22d23
Update variable name
hannobraun Sep 8, 2022
546c508
Update variable name
hannobraun Sep 8, 2022
15cb961
Update doc comments
hannobraun Sep 8, 2022
9941078
Update variable name
hannobraun Sep 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update struct name
hannobraun committed Sep 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 57a82adc2b413511765a31101ae2bfa2a9c57adb
6 changes: 3 additions & 3 deletions crates/fj-kernel/src/builder/edge.rs
Original file line number Diff line number Diff line change
@@ -6,12 +6,12 @@ use crate::objects::{
};

/// API for building an [`HalfEdge`]
pub struct EdgeBuilder {
pub struct HalfEdgeBuilder {
surface: Surface,
}

impl EdgeBuilder {
/// Construct a new instance of [`EdgeBuilder`]
impl HalfEdgeBuilder {
/// Construct a new instance of [`HalfEdgeBuilder`]
///
/// Also see [`HalfEdge::build`].
pub fn new(surface: Surface) -> Self {
2 changes: 1 addition & 1 deletion crates/fj-kernel/src/builder/mod.rs
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ mod solid;
pub use self::{
curve::{CurveBuilder, GlobalCurveBuilder},
cycle::CycleBuilder,
edge::EdgeBuilder,
edge::HalfEdgeBuilder,
face::{FaceBuilder, FacePolygon},
shell::ShellBuilder,
sketch::SketchBuilder,
8 changes: 4 additions & 4 deletions crates/fj-kernel/src/objects/edge.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::fmt;

use crate::{algorithms::reverse::Reverse, builder::EdgeBuilder};
use crate::{algorithms::reverse::Reverse, builder::HalfEdgeBuilder};

use super::{Curve, GlobalCurve, GlobalVertex, Surface, Vertex};

@@ -13,9 +13,9 @@ pub struct HalfEdge {
}

impl HalfEdge {
/// Build an edge using [`EdgeBuilder`]
pub fn build(surface: Surface) -> EdgeBuilder {
EdgeBuilder::new(surface)
/// Build an edge using [`HalfEdgeBuilder`]
pub fn build(surface: Surface) -> HalfEdgeBuilder {
HalfEdgeBuilder::new(surface)
}

/// Create a new instance of `Edge`