-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model version check is disabled on Windows #1307
Comments
I went over the version comparison code with a fine comb and found (and fixed!) a potential soundness hole. I don't know if that was actually the problem reported in #1303, but if it was, it's possible that the version check can be enabled on Windows without further changes. |
I've just pulled the latest Btw is it possible to somehow filter |
Thank you! Such a subtle thing. I wasn't very optimistic that this would actually solve it!
Yes: I think you can go even more fine-grained, by specifying this on the module level. And you can probably chain multiple directives using |
When loading a model, the Fornjot app checks the Fornjot version that this model model uses, to prevent mystery errors due to incompatibilities. This check is currently disabled on Windows. There's a bug that prevents it from working there. See #1303 for context.
It would be great if we fixed that bug, and enabled the same version check on all platforms. Unfortunately, I don't have access to a Windows machine and lack Windows expertise. Labeling as https://github.com/hannobraun/Fornjot/labels/help%20wanted, as help would be especially appreciated!
The text was updated successfully, but these errors were encountered: