Merge pull request #2119 from hannobraun/fix

Fix `UpdateShell::remove_face`
hannobraun · Nov 29, 2023 · 5084ed5 · 5084ed5
2 parents 83691f6 + e5420f2
commit 5084ed5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/crates/fj-core/src/operations/build/edge.rs → ...fj-core/src/operations/build/half_edge.rs b/crates/fj-core/src/operations/build/edge.rs → ...fj-core/src/operations/build/half_edge.rs
diff --git a/crates/fj-core/src/operations/build/mod.rs b/crates/fj-core/src/operations/build/mod.rs
@@ -18,8 +18,8 @@
 //! components.
 
 mod cycle;
-mod edge;
 mod face;
+mod half_edge;
 mod region;
 mod shell;
 mod sketch;
@@ -28,8 +28,8 @@ mod surface;
 
 pub use self::{
     cycle::BuildCycle,
-    edge::BuildHalfEdge,
     face::{BuildFace, Polygon},
+    half_edge::BuildHalfEdge,
     region::BuildRegion,
     shell::{BuildShell, TetrahedronShell},
     sketch::BuildSketch,

diff --git a/crates/fj-core/src/operations/update/shell.rs b/crates/fj-core/src/operations/update/shell.rs
@@ -79,7 +79,7 @@ impl UpdateShell for Shell {
         let faces = self
             .faces()
             .iter()
-            .filter(|face| face.id() == handle.id())
+            .filter(|face| face.id() != handle.id())
             .cloned();
 
         Shell::new(faces)