Merge pull request #1409 from hannobraun/partial

Update doc comments in partial object API

crates/fj-kernel/src/algorithms/approx/curve.rs

@@ -213,10 +213,7 @@ mod tests {
     fn approx_line_on_flat_surface() {
         let mut services = Services::new();
 
-        let surface =
-            PartialSurface::from_axes(GlobalPath::x_axis(), [0., 0., 1.])
-                .build(&services.objects)
-                .insert(&mut services.objects);
+        let surface = services.objects.surfaces.xz_plane();
         let mut curve = PartialCurve {
             surface: Some(surface),
             ..Default::default()
@@ -297,10 +294,7 @@ mod tests {
     fn approx_circle_on_flat_surface() {
         let mut services = Services::new();
 
-        let surface =
-            PartialSurface::from_axes(GlobalPath::x_axis(), [0., 0., 1.])
-                .build(&services.objects)
-                .insert(&mut services.objects);
+        let surface = services.objects.surfaces.xz_plane();
         let mut curve = PartialCurve {
             surface: Some(surface),
             ..Default::default()

crates/fj-kernel/src/partial/traits.rs

@@ -1,21 +1,6 @@
 use crate::{objects::Objects, services::Service};
 
 /// Implemented for objects that a partial object type exists for
-///
-/// # Implementation Note
-///
-/// This trait is usually implemented for object types themselves, but types
-/// that are already managed in the centralized object storage ([#1021])
-/// implement this trait for `Handle<T>` instead. This is necessary, due to the
-/// use of this type in [`MaybePartial`], but leads to some not so nice
-/// inconsistencies.
-///
-/// Once [#1021] is addressed and all types are managed in the centralized
-/// object storage, this should be changed to all object types implement this
-/// directly.
-///
-/// [#1021]: https://github.com/hannobraun/Fornjot/issues/1021
-/// [`MaybePartial`]: super::MaybePartial
 pub trait HasPartial {
     /// The type representing the partial variant of this object
     type Partial: Partial<Full = Self>;
@@ -60,10 +45,11 @@ pub trait HasPartial {
 /// # Implementation Note
 ///
 /// It would be nicer to require an [`Into`] bound instead of [`From`] (see
-/// documentation of those types for more information). But I think we'd need a
-/// `where` clause on the associated type to specify that, which is unstable. It
-/// should become stable soon though, together with generic associated types:
-/// <https://github.com/rust-lang/rust/issues/44265>
+/// documentation of those types for more information). Unfortunately, this
+/// doesn't seem to be possible without a `where` clause on `HasPartial`, which
+/// significantly reduces the convenience of using that trait, as the `where`
+/// clause needs to be repeated everywhere `HasPartial` is specialized as a
+/// bound.
 pub trait Partial: Default + for<'a> From<&'a Self::Full> {
     /// The type representing the full variant of this object
     type Full;