Add Plane::is_parallel_to_vector

hannobraun · Sep 30, 2022 · 1f7be33 · 1f7be33
1 parent 8db6db1
commit 1f7be33
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/crates/fj-kernel/src/algorithms/intersect/ray_face.rs b/crates/fj-kernel/src/algorithms/intersect/ray_face.rs
@@ -27,10 +27,7 @@ impl Intersect for (&HorizontalRayToTheRight<3>, &Face) {
             ),
         };
 
-        let plane_and_ray_are_parallel =
-            plane.normal().dot(&ray.direction()) == Scalar::ZERO;
-
-        if plane_and_ray_are_parallel {
+        if plane.is_parallel_to_vector(&ray.direction()) {
             let a = plane.origin();
             let b = plane.origin() + plane.u();
             let c = plane.origin() + plane.v();

diff --git a/crates/fj-math/src/plane.rs b/crates/fj-math/src/plane.rs
@@ -56,6 +56,11 @@ impl Plane {
         (distance, normal)
     }
 
+    /// Determine whether the plane is parallel to the given vector
+    pub fn is_parallel_to_vector(&self, vector: &Vector<3>) -> bool {
+        self.normal().dot(vector) == Scalar::ZERO
+    }
+
     /// Project a line into the plane
     pub fn project_line(&self, line: &Line<3>) -> Line<2> {
         let line_origin_relative_to_plane = line.origin() - self.origin();