Prepare HalfEdgeBuilder for HalfEdge/PartialHalfEdge unification
#1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `HalfEdgeBuilder::update_as_circle_from_radius`.
Replace `HalfEdgeBuilder::update_as_arc`.
What the comment describes was new when I wrote it, so it felt worth calling out. Now everything has settled down, and if this isn't properly explained, this comment is not thr right place to do it.
Replace `HalfEdgeBuilder::update_as_line_segment`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once
HalfEdgeandPartialHalfEdgeare unified, which should result in something that looks almost, if not exactly, likeHalfEdgedoes now, the unifiedHalfEdgewill no longer be mutable. This pull request preparesHalfEdgeBuilderfor that future, by redesigning it in a way that doesn't require its caller to mutate thePartialHalfEdges it produces.This is another big step towards addressing #1570.