Improvement + Fix: Personal Bests Gain #2996
Open
+59
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement + Fix: Personal Bests Gain
CalMWolfs
requested changes
Nov 28, 2024
| desc = "Show in chat how much more FF you would have gotten over your previous record if personal best fortune cap was not 100" | ||
| ) | ||
| @ConfigEditorBoolean | ||
| @FeatureToggle |
There was a problem hiding this comment.
As I wouldnt consider this here a standalone feature this config option doesnt need a feature toggle annotation
Comment on lines
-214
to
-221
| @Expose | ||
| @ConfigOption( | ||
| name = "Personal Best Increase FF", | ||
| desc = "Show in chat how much more FF you get from farming contest personal best bonus after beating the previous record." | ||
| ) | ||
| @ConfigEditorBoolean | ||
| @FeatureToggle | ||
| public boolean contestPersonalBestIncreaseFF = true; |
There was a problem hiding this comment.
because you are moving this option, you need to add a config fix so that if people turned it off before it wont turn back on, search the codebase for examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Fixes incorrect personal best gain calculations if new personal best is over the max pb, adds option to show overflow personal bests.
Changelog Improvements
Changelog Fixes