Unreal context menus

[JLHayde]

An update that adds an option to setup menus in the context menu of an asset

[hannesdelbeke]

This looks really cool, I do have some concerns regarding this feature only wokring in Unreal.
Ideally the unimenu interface for all apps only adds new args if these are supported in all, or most apps. (see the features overview)
Let's see if we can make this feature a bit more generic.

[hannesdelbeke]

when testing out the sample code on your branch, i get an error

import unreal_context_menu

LogPython: Error: Traceback (most recent call last):
LogPython: Error:   File "<string>", line 1, in <module>
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
LogPython: Error:     return original_import(name, *args, **kwargs)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unreal_context_menu.py", line 72, in <module>
LogPython: Error:     app_node = node.setup(backlink=False)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\unreal.py", line 26, in setup
LogPython: Error:     super().setup(parent_app_node=parent_app_node, backlink=backlink)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\_abstract.py", line 214, in setup
LogPython: Error:     self.app_node = self._setup_sub_menu(parent_app_node=parent_app_node)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\unreal.py", line 40, in _setup_sub_menu
LogPython: Error:     return parent_app_node.add_sub_menu(
LogPython: Error: AttributeError: 'NoneType' object has no attribute 'add_sub_menu'

[JLHayde]

when testing out the sample code on your branch, i get an error
...

I've just tested on a couple projects, and also tested with the branch pulled from git and haven't got the error.
which UE version are you using? I'm currently on 5.2

[hannesdelbeke]

I've just tested on a couple projects, and also tested with the branch pulled from git and haven't got the error. which UE version are you using? I'm currently on 5.2

i'm on 5.0.2. i tested another sample demo any_dcc_test and that one works (but with a bug #50)

[JLHayde]

i've run a the sample on another machine and with 5.0.3 and I cant seem to get the error

The only thing that could be different is that your running from ..../Unreal Projects\MyProject\Content\Python\Lib\site-packages and in my launcher I'm adding to PYTHONPATH. but that shouldn't make a difference

Edit:
i have manged to get the error by changing 'root_menu' to something like ContentBrowser.AssetContextMenu.Sta
in the sample. this would be correct as that menu doesn't exists. maybe this menu has not been registered at the time the the sample was run?

[hannesdelbeke]

1. just retried today and works now 🤷
2. double checked that wasn't on your branch. (it added the menu to the top menu)
   after swapping to yours it breaks again. same error
3. got it to work, needed to go to a folder with assets, and right click the menu before running the script. this ensures the root menu exists.
   now it runs correctly and adds the menu to the right click menu.

• might have to look at extend_menu https://docs.unrealengine.com/4.26/en-US/PythonAPI/class/ToolMenus.html#unreal.ToolMenus it can handle cases where the menu doesn't exist yet.

[hannesdelbeke]

FYI, i suggest to split this up in separate PRs, i noticed you also integrated icon and separator.
It's easier for me to review 1 feature at a time.
deffo want to integrate this though

• with the parentpath change, i think we don't need the rootmeno / context menu change from this PR anymore.

[JLHayde]

Sure ill make another pr with just the icons.

Its strange that it does not work without opening the context menu first. I'm running the code on init_unreal.py so its happening at the earliest it can. I'll look into the extend method. and also exclude the separator and icon changes from this pull

[hannesdelbeke]

ye by default unreal starts in site package folder, which has no assets.
the context menu doesn't has the section we are adding to either

what is still left from this PR? since we can use parent_path we dont need root menu anymore
and you ll move icons and separator to a new PR.

[JLHayde]

The 'menu_section' kwarg will be needed so the user can specify in the which area of the context menu to put the menu/action

[hannesdelbeke]

The 'menu_section' kwarg will be needed so the user can specify in the which area of the context menu to put the menu/action

Ah yes, that goes together with the separator I believe

[JLHayde]

Pulled your latest changes and now set the menu_section in data from the kwarg. so this can be re-used later in the icons and separator fix