Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API reference links on documentation page /api/classes/config.html #1395

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Mar 21, 2024

Context

The links work correctly on page https://hyperformula.handsontable.com/api/interfaces/configparams.html but not on page https://hyperformula.handsontable.com/api/classes/config.html.

This PR changes the link formats so they work on both pages.

How did you test your changes?

  • local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Bug]: Broken link to precisionEpsilonoption within the smartRounding option in the docs #1302

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Mar 21, 2024
@sequba sequba requested a review from evanSe March 21, 2024 14:57
Copy link

github-actions bot commented Mar 21, 2024

Performance comparison of head (4ef0fd8) vs base (34d761a)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 536.46 | 556.74 | +3.78%
                                      Sheet B | 174.31 | 178.11 | +2.18%
                                      Sheet T | 151.65 | 153.72 | +1.36%
                                Column ranges | 554.95 | 556.27 | +0.24%
Sheet A:  change value, add/remove row/column |  14.45 |  15.72 | +8.79%
 Sheet B: change value, add/remove row/column |  130.9 | 134.28 | +2.58%
                   Column ranges - add column | 154.04 | 154.96 | +0.60%
                Column ranges - without batch | 463.15 | 452.76 | -2.24%
                        Column ranges - batch | 121.01 | 119.78 | -1.02%

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (34d761a) to head (4ef0fd8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1395   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files          169      169           
  Lines        14421    14421           
  Branches      3100     3100           
========================================
  Hits         14041    14041           
  Misses         377      377           
  Partials         3        3           
Files Coverage Δ
src/Config.ts 98.00% <ø> (ø)

@sequba sequba merged commit ab6ef8e into develop Mar 26, 2024
23 checks passed
@sequba sequba deleted the issue/feature-1302 branch March 26, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants