fix: 将style中的属性转换为合法的style={{}}格式 #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2023 15:51
qican77
reviewed
Sep 7, 2023
packages/taroize/src/wxml.ts
Outdated
| styleAttrs.forEach((attr) => { | ||
| const [attrName, value] = attr.split(':') | ||
| if (attrName) { | ||
| styleKeys.push({ attrName, value }) |
packages/taroize/src/wxml.ts
Outdated
| styleKeys.push({ attrName, value }) | ||
| } | ||
| }) | ||
| styleNameToCamelCase(styleKeys) |
packages/taroize/src/wxml.ts
Outdated
|
|
||
| // 把 style 中 {{}} 转为 ${} 格式 | ||
| if (name.name === 'style' && t.isStringLiteral(path.node.value)) { | ||
| const styleValue = path.node.value as any |
There was a problem hiding this comment.
这里可以封装成一个函数parseStyleAttrs，解析样式属性，下面的函数是转换样式属性
qican77
reviewed
Sep 7, 2023
packages/taroize/src/wxml.ts
Outdated
| const matchs = attrValueReg.exec(attr.value) | ||
| if (matchs !== null) { | ||
| // 获取{{}}模版左右位置的值 | ||
| const tempLeftValue = attr.value.split('{{') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
convertor在做转换时并没有对style的静态内联样式和动态内联样式做转换，该commit主要对style属性名转小驼峰。而对于含有变量的属性值转换为${}形式。对于静态内联样式则是将其转换为react识别的style={{}}格式
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: