fix: 更改/开头路径导入报错问题 #165
Closed
fix: 更改/开头路径导入报错问题 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qican77
reviewed
Sep 5, 2023
| @@ -23,31 +23,38 @@ export function getPkgVersion (): string { | |||
| return require(path.join(getRootPath(), 'package.json')).version | |||
| } | |||
|
|
|||
| function getRelativePath (rootPath: string, sourceFilePath: string, oriPath: string) { | |||
| function revertScriptPath (p: string, extArrs = SCRIPT_EXT): string { | |||
| if (relativePath.indexOf('.') !== 0) { | ||
| return './' + relativePath | ||
| const absSearchPath = revertScriptPath(path.resolve(sourceFilePath, '..' + oriPath)) | ||
| let absolutePath = path.relative(path.dirname(sourceFilePath), absSearchPath) |
| relativePath = promoteRelativePath(relativePath) | ||
| if (relativePath.indexOf('.') !== 0) { | ||
| return './' + relativePath | ||
| const absSearchPath = revertScriptPath(path.resolve(sourceFilePath, '..' + oriPath)) |
| // 微信小程序中js文件的引用可不加后缀，需考虑 | ||
| return `./${oriPath}.js` | ||
| const vpath = revertScriptPath(path.resolve(sourceFilePath, '..', oriPath)) | ||
| const absolutePath = path.relative(path.dirname(sourceFilePath), vpath) |
| return `./${oriPath}.js` | ||
| const vpath = revertScriptPath(path.resolve(sourceFilePath, '..', oriPath)) | ||
| const absolutePath = path.relative(path.dirname(sourceFilePath), vpath) | ||
| if (vpath) { |
qican77
reviewed
Sep 5, 2023
| @@ -23,31 +23,38 @@ export function getPkgVersion (): string { | |||
| return require(path.join(getRootPath(), 'package.json')).version | |||
| } | |||
|
|
|||
| function getRelativePath (rootPath: string, sourceFilePath: string, oriPath: string) { | |||
| function revertScriptPath (p: string, extArrs = SCRIPT_EXT): string { | |||
Vector-Hope
reviewed
Sep 5, 2023
| } else if (fs.existsSync(`${p}${item}`)){ | ||
| return `${p}${item}` | ||
| } | ||
| } |
There was a problem hiding this comment.
遍历如果可以的话，尽量用对象或数组自身的方法，这里可以用foreach，for循环中的索引命名也尽量有意义。
| let absolutePath = path.relative(path.dirname(sourceFilePath), absSearchPath) | ||
| absolutePath = promoteRelativePath(absolutePath) | ||
| if (absolutePath.indexOf('.') !== 0) { | ||
| return './' + absolutePath |
There was a problem hiding this comment.
多处的字符串拼接，尽量采取同一种形式，建议采用模板字符串继续字符串拼接，并且统一
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
更改/开头路径导入报错问题
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: