Return value for Handlebars.noConflict(); #959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix global var lookup error when undefined
Unravel mustache loop and hydrate function.
Also solidifying / making sense of helpers.
Example templates to give you an idea:
{{foo}}<span></span>
...
function template(context, options) {
if (cachedFragment === null) {
cachedFragment = build(dom);
}
var fragment = cachedFragment.cloneNode(true);
var helpers = options && options.helpers || {};
var placeholder0 = new Placeholder(fragment,0,1);
helpers.CONTENT(placeholder0, "foo", context, [], {escaped:true}, helpers);
return fragment;
}
<span>{{foo}}</span>{{foo}}
...
function template(context, options) {
if (cachedFragment === null) {
cachedFragment = build(dom);
}
var fragment = cachedFragment.cloneNode(true);
var helpers = options && options.helpers || {};
var placeholder0 = new Placeholder(fragment.childNodes[0],-1,-1), placeholder1 = new Placeholder(fragment,0,1);
helpers.CONTENT(placeholder0, "foo", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder1, "foo", context, [], {escaped:true}, helpers);
return fragment;
}
{{foo}}<span>{{bar}}<a>{{baz}}<em>{{boo}}{{brew}}</em>{{bat}}</a></span>
<span><span>{{flute}}</span></span>{{argh}}
...
function template(context, options) {
if (cachedFragment === null) {
cachedFragment = build(dom);
}
var fragment = cachedFragment.cloneNode(true);
var helpers = options && options.helpers || {};
var placeholder0 = new Placeholder(fragment,0,1), parent0 = fragment.childNodes[1], placeholder1 = new Placeholder(parent0,-1,0), parent1 = parent0.childNodes[0], placeholder2 = new Placeholder(parent1,-1,0), parent2 = parent1.childNodes[0], placeholder3 = new Placeholder(parent2,-1,0), placeholder4 = new Placeholder(parent2,0,-1), placeholder5 = new Placeholder(parent1,0,-1), placeholder6 = new Placeholder(fragment.childNodes[2].childNodes[0],-1,-1), placeholder7 = new Placeholder(fragment,2,3);
helpers.CONTENT(placeholder0, "foo", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder1, "bar", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder2, "baz", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder3, "boo", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder4, "brew", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder5, "bat", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder6, "flute", context, [], {escaped:true}, helpers);
helpers.CONTENT(placeholder7, "argh", context, [], {escaped:true}, helpers);
return fragment;
}
Add passing test for compiling SVG elements
TODO: write tests for this
…present. Need to discuss this with @machty
Fix typo in ARCHITECTURE.md
Fix typo in readme
Conflicts: .gitignore .jshintrc .travis.yml Gruntfile.js LICENSE package.json
|
I think you selected the wrong branch when creating your pull request. Can you reopen against your own branch? |
|
This is really embarrassing: I forked your project into my account, then Error message: There isn't anything to compare wycats:master and What am I missing here? On 02/11/2015 06:30 AM, Kevin Decker wrote:
|
|
General flow that I use when submitting a PR from a fork: You then make all of the changes that you need, push, and open the the PR. Upstream here is the remote for the source repo, for handlebars you'd need to set that up, something like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our discussion #887, it would be great if the noConflict() method returned an instance of Handlebars.
The docs at http://handlebarsjs.com/reference.html (see paragraph Handlebars.noConflict()) already suggests it does.