Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ember testing process #641

Merged
merged 1 commit into from
Dec 24, 2013
Merged

Document ember testing process #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ External Resources

* [Gist about Synchronous and asynchronous loading of external handlebars templates](https://gist.github.com/2287070)

Have a project using Handlebars? Send us a [pull request](https://github.com/wycats/handlebars.js/pull/new/master)!
Have a project using Handlebars? Send us a [pull request][pull-request]!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah is a neat trick that @fivetanley showed me.
265d624#diff-0a369498a5a8db3ac8fa606b544c9810R24


Helping Out
-----------
Expand All @@ -412,6 +412,18 @@ Feel free to contact commondream or wycats through GitHub with any other
questions or feature requests. To submit changes fork the project and
send a pull request.

### Ember testing

The current ember distribution should be tested as part of the handlebars release process. This requires building the `handlebars-source` gem locally and then executing the ember test script.

```sh
grunt build release
export HANDLEBARS_PATH=`pwd`

cd $emberRepoDir
bundle exec rake test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, Ember's gemspec points to a specific version of Handlebars. If Handlebars is following SemVer, we can probably change it to "~> 1.0". This would mean no modifying the Ember gemspec. Since Ember uses Bundler, we could actually have the user just add the following to the Ember Gemfile:

gem "handlebars-source", :path => "path/to/handlebars/dist/components"

I'm open to adding an ENV var conditional to the Ember Gemfile to make this easier. Something along the lines of:

if ENV['HANDLEBARS_PATH']
   gem "handlebars-source", :path => ENV['HANDLEBARS_PATH']+'/dist/components'
end

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like it would make things a lot easier!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emberjs/ember.js@3daf93c

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'll give this a spin.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And quite a bit later: yes this works thanks for updating this.

```

### Releasing

Handlebars utilizes the [release yeoman generator][generator-release] to perform most release tasks.
Expand All @@ -435,3 +447,4 @@ Handlebars.js is released under the MIT license.
[bower-repo]: https://github.com/components/handlebars.js
[builds-page]: http://builds.handlebarsjs.com.s3.amazonaws.com/bucket-listing.html?sort=lastmod&sortdir=desc
[generator-release]: https://github.com/walmartlabs/generator-release
[pull-request]: https://github.com/wycats/handlebars.js/pull/new/master