Loading pre-compiled templates is broken when using AMD and v1.1

[zvikico]

In the current master, v1.1, the library loading is adapted to using AMDs (I use require.js). When using an require.js, for example, the Handlebars is no longer a global var. This works OK if you've used require.js properly, since you are supposed to start your module with a block that looks like this:

define([ "handlebars"], function( Handlebars ) {
     ...
});

This works well. But, compiled templates are not defined that way. The code assumes templates are global. Here's a sample code I use:

define([ "handlebars"], function( Handlebars ) {

   Handlebars.registerHelper(...);

   require(["js/templates/temp1.js", "js/templates/temp2.js"], function() { 
        ...
   }
});

The helper registration works, because Handlebars is defined. However, the templates loading failed because it is not. I could add something like:

   window.Handlebars = Handlebars;
   require(["js/templates/temp1.js", "js/templates/temp2.js"], function() { 
        ...
   }

And that would fix the problem. But that's not really backwards compatible...

[blessanm86]

If your templates are precompiled, you just need to require the js file and
the template should be accessible at Handlebars.templates.temp1
Is this what you tried?
On Jun 26, 2013 8:09 PM, "Zviki Cohen" [email protected] wrote:

In the current master, v1.1, the library loading is adapted to using AMDs
(I use require.js). When using an require.js, for example, the Handlebars
is no longer a global var. This works OK if you've used require.js
properly, since you are supposed to start your module with a block that
looks like this:

define([ "handlebars"], function( Handlebars ) {
...});

This works well. But, compiled templates are not defined that way. The
code assumes templates are global. Here's a sample code I use:

define([ "handlebars"], function( Handlebars ) {

Handlebars.registerHelper(...);

require(["js/templates/temp1.js", "js/templates/temp2.js"], function() {
...
}});

The helper registration works, because Handlebars is defined. However, the
templates loading failed because it is not. I could add something like:

window.Handlebars = Handlebars;
require(["js/templates/temp1.js", "js/templates/temp2.js"], function() {
...
}

And that would fix the problem. But that's not really backwards
compatible...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/563
.

[zvikico]

Yeah. Exactly. But the pre-compiled template syntax does not use AMD.

[blessanm86]

There is an amd flag for that. This is the command that I normally use

Handlebars templates/>pagetemplates.js -a -e html

This is supported in the latest precompiler. Some options are not in the
doc. I've sent a pull request(#555) to include them.
On Jun 26, 2013 8:25 PM, "Zviki Cohen" [email protected] wrote:

Yeah. Exactly. But the pre-compiled template syntax does not use AMD.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/563#issuecomment-20053083
.

[zvikico]

Good. I'll try it. So it could be a documentation issue. There should be some note in the changelog or docs explaining the steps necessary to move to full AMD support.

[kpdecker]

@zvikico Did the flag work for you?

[zvikico]

Yes, it does.

I'm glad to see AMD support is being introduced to Handlebars.js. I've been a huge fan of require.js for a long time now and this is a very important step for Handlebars.

Still, it means that 1.1 won't be a drop-in replacement for many people out there. That's something to consider.

[kpdecker]

Heads up: under 1.1 we moved to ES6 modules which now require default dereference for AMD loaders. This is resolved by e9350f2 but templates should be recompiled when upgrading to the formal 1.1 release that I hope to get out shortly.

[kpdecker]

Released in 1.1.0