-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop individual AMD files from build output #1096
Comments
A better option is to add the necessary files to the |
@jonschlinkert Agree. |
What is the impact of having these files? I've always assumed that disk space is cheap on the server but perhaps there are use cases that are impacted more. Including these files was by design for the most part to try to get people out of the cycle of having version mismatches between the precompiler and the clients that they are using but we might be able to drop the amd specific files, I don't think the direct AMD linking case ever really worked out for anyone due to the confusion around |
Any feedback here? |
Personally I wouldn't create a new major version for this. 1.5 MB is not that much. But if a new major comes around anyway, I would like to see it in there, for the following reasons:
My more general point is: Just because disk space is cheap on the server doesn't mean we should waste it. It may not have an impact on a production machine, but it certainly has during development. My bootprint-package needs 62 MB of hard-disk-space and if you don't have a recent computer with SSDs, you have waited quite long time to download and install everything. Waiting is not a good user-experience. |
totally agree, this is mostly just a nice to have. My main interest in this is that downloads and init times are faster when fewer files are in the dependency tree. The bigger the dependency tree, the bigger the impact. |
These files have been a source of much confusion and I think that people aren't really using them in light of the UMD implementation. I still think that npm's dedupe behavior takes away a lot of the concerns here but I think we can get away with dumping the files on the next major, whenever that may be. |
I would like to take the stress out of my comment a little: With |
Users can utilize the UMD library if they are still using require.js and if they need to have specific modules, they can consume the cjs or es6 modules via webpack or similar. Fix for #1096
Users can utilize the UMD library if they are still using require.js and if they need to have specific modules, they can consume the cjs or es6 modules via webpack or similar. Fix for #1096
Suggest to ignore amd dist on npm module. It's almost 1.5mb.
The text was updated successfully, but these errors were encountered: