Update Wikimate::token() to remember CSRF token (fixes #115) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldyrious
reviewed
Aug 24, 2021
waldyrious
approved these changes
Aug 24, 2021
|
Not really, but I think I'll need to rebase/push for the merge conflict first, right? Edit: Done, conflict resolved, ready for merge. |
Xymph
force-pushed
the
122-store-csrf-token
branch
from
7ba2a86 to
2a8a803
Compare
|
I think it's nice to rebase even when there aren't conflicts, to avoid crossing branches and provide a semi-linear git graph. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #115. Storing and re-using the token reduces the number of API calls when invoking multiple edit/delete/etc actions in a session, as is typical bot behavior.
The error value of
token()is also changed tonull(falseshould only be used by boolean methods). Sincetoken()is an internal method, I don't consider this an API-breaking change.