Optimize aligners over FASTQ fragments on-demand #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not complete, it's a request for comments.
There is a compiler option that chooses which ones we want to run in parallel, and whether missing the optimization should raise an exception.
|
It fixes #157 |
| | other -> | ||
| begin match option with | ||
| | Some `Silent | ||
| | None -> `Not_caught |
There was a problem hiding this comment.
I think the default response for when a compiler optimization cannot be made, but is expected by the user, should be noisy alert, not silent failure and continuing with the compilation.
There was a problem hiding this comment.
Ah I see; this is when there is no optimization specified. I recall my previous comment.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is