-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
touchcancel fires a tap event #324
Comments
I can confirm that the same behaviour is exhibited by IE10 using touch, and just came here to open an issue about it. My quick fix was to monkey-patch Hammer.detection.extendEventData to include a 'cancelled' property on the gesture object, which I can then check when relevant. Perhaps this would be a better approach than introducing a BC break? |
Issuebot: |
touchcancel
should not trigger hammer events where possible, specificallytap
. Onlytouchend
should trigger a tap.#152 noted how Android fires a
touchcancel
when a scroll begins. This sometimes causes atap
event to fire if the cancel happens soon enough. It is easy to cause scrolls to nearly always causetap
to fire by settingtap_max_distance: 50
.This seems to be device dependent but definitely happens on a Nexus 7 running Android 4.2.2 and Chrome 28.0.1500.94.
The fix would mean distinguishing a gesture ending on an "end" event from one ending on "cancel" and may be a hammer-wide change. @jtangelder what are your thoughts on this? I'm happy to do the PR.
The text was updated successfully, but these errors were encountered: