Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using pytest-runner #31

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

setup_requires and tests_requires are firmly deprecated by setuptools
upstream, and pytest-runner similarly, since it makes use of
functionality that setuptools would like to remove. Stop setting
{setup,test}_requires in setup.py, and remove pytest-runner from
Pipfile.

Fixes #29

setup_requires and tests_requires are firmly deprecated by setuptools
upstream, and pytest-runner similarly, since it makes use of
functionality that setuptools would like to remove. Stop setting
{setup,test}_requires in setup.py, and remove pytest-runner from
Pipfile.

Fixes hamidfzm#29
@hamidfzm
Copy link
Owner

Please fix tests to merge this,

@s-t-e-v-e-n-k s-t-e-v-e-n-k force-pushed the remove-pytest-runner branch 5 times, most recently from 86dc71b to 07b3506 Compare March 29, 2022 04:33
Since python setup.py install and setup.py test are also firmly
deprecated, use pipenv and pytest directly.
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #31 (c11f9ca) into master (8ea133b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files           1        1           
  Lines          79       79           
=======================================
  Hits           76       76           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea133b...c11f9ca. Read the comment docs.

@s-t-e-v-e-n-k
Copy link
Contributor Author

I have successfully slayed the dragon of failing tests, thanks,

@hamidfzm hamidfzm merged commit 49334ac into hamidfzm:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest-runner not required
3 participants