Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add LevelProperty public attribute to all the levels #22

Merged
merged 9 commits into from
Jun 6, 2023
Merged

[ENH] Add LevelProperty public attribute to all the levels #22

merged 9 commits into from
Jun 6, 2023

Conversation

adam2392
Copy link
Contributor

@adam2392 adam2392 commented May 31, 2023 •
edited
Loading

Towards: #19

Adds LevelProperty() constexpr function to allow each class access to the levelproperties during compile time, without explicitly writing the class type.

adam2392
adam2392 commented May 31, 2023
View reviewed changes
test/source/dense_test.cpp Outdated Show resolved Hide resolved
@adam2392 adam2392 mentioned this pull request May 31, 2023
Closed
adam2392
adam2392 commented May 31, 2023
View reviewed changes
Copy link
Contributor Author

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added unit-tests to check for these properties, and also added a BaseCase test where possible

adam2392
adam2392 commented May 31, 2023
View reviewed changes
Copy link
Contributor Author

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean up the commented code in the unit-tests once you both have a chance to review the code

@adam2392
Level to lower-case
5e72277 
Signed-off-by: Adam Li <[email protected]>
@adam2392
Copy link
Contributor Author

adam2392 commented Jun 2, 2023

If this is good design, then I can revisit the PR on co iteration.

@adam2392
Fix new design
6a73b73 
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 mentioned this pull request Jun 5, 2023
Open
@hameerabbasi
Copy link
Owner

hameerabbasi commented Jun 6, 2023 •
edited
Loading

@bharath2438 Could you give this a shallow review? I'll merge on your approval.

bharath2438
bharath2438 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@bharath2438 bharath2438 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these look good.

@hameerabbasi hameerabbasi merged commit 9f47a2c into hameerabbasi:main Jun 6, 2023
@adam2392 adam2392 deleted the levelprops branch June 6, 2023 13:36
@hameerabbasi
Copy link
Owner

Merging, thanks for the fixes, @adam2392!

@adam2392 adam2392 mentioned this pull request Aug 31, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath2438 bharath2438 bharath2438 approved these changes

@hameerabbasi hameerabbasi Awaiting requested review from hameerabbasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam2392 @hameerabbasi @bharath2438