Merge core and library, revive hamcrest-integration #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumbarumba
changed the title
|
I would have thought this would be version 1.4, rather than 2? It's a change in the packaging, rather than breaking code. |
|
That's true, @sf105. However, we have already released a version 2.0.0.0 of something. Unfortunately, we are unable to remove it from Maven Central. I think it would be highly confusing to have a version 1.4 artifact that is more recent than a version 2.0.0.0 artifact, even it it was a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change to the project structure, but there are no changes to any Java code.
After chatting with @sf105 on Issue #224, I reworked the way that the code is organised and packaged. The more I think about it, the less I like the idea of preserving the same packaging. It's been such a long time between releases, I don't think there's a huge benefit in keeping the old packaging around.
As this is a breaking change due to the repackaging, the version has changed from
1.4-SNAPSHOTto2.1-SNAPSHOT. I realise that the Java API hasn't actually changed, but since there is already a version2.0.0.0published on Maven Central, the next version published must be incrementally higher than that, at a minimum.I have revived hamcrest-integration as separate subproject. This was done by unzipping
hamcrest-integration-1.3.jardownloaded from Maven Central. Unfortunately, the corresponding code available from the archived hamcrest-java on Google Code appeared out of date. I could not see test code for java-integration (I had a poke around the Google Code archive, but no luck there).Salient points:
hamcrestis the result of merginghamcrest-coreandhamcrest-library.hamcrest-integrationremains an independent project.hamcrest-integrationremains only as a 1.3 line bugfix backstop. It is not published, and its version is pinned at1.3.1-SNAPSHOT.hamcrest-allorjava-hamcrest), which means only a single artefact is published:org.hamcrest:hamcrest:<version>(jar, sources and javadoc)