Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build separate jars for core, library, and all. #228

Merged
merged 3 commits into from
Nov 10, 2018
Merged

Build separate jars for core, library, and all. #228

merged 3 commits into from
Nov 10, 2018

Conversation

tumbarumba
Copy link
Member

This is done by converting to a multi-project gradle build, with subprojects for hamcrest-core and hamcrest-library. The root project is responsible for combining all the individual jars into hamcrest-all.jar, as well as configuring the publishing.

Note that this changes the version from '2.0.0.0' to '1.4-SNAPSHOT'

This is done by converting to a multi-project gradle build, with
subprojects for `hamcrest-core.jar` and `hamcrest-library.jar`. The
root project is responsible for combining all the individual jars
into `hamcrest-all.jar`, as well as configuring the publishing.
@tumbarumba tumbarumba merged commit c9522e3 into hamcrest:master Nov 10, 2018
@sf105
Copy link
Member

sf105 commented Nov 10, 2018

I thought we were just going to have one big jar and drop the smaller ones? Basically, everything that just depends on the JVM ad there’s not much point in distinguishing between core and library.

@tumbarumba
Copy link
Member Author

Ah, I misunderstood the conversation last Tuesday, where we were discussing keeping APIs the same as 1.3 (it was in a pub and quite loud!), as well as your comments on Issue #224, where you were keeping hamcrest-integration as a separate jar (it has dependencies outside the jdk). For some reason I had told myself you meant that all the jar packages should stay the same.

I can change this, though I think we still need the multi-project aspect. If I bring the integration code back from Google Code, we can keep that as a separate jar, and merge core and library into a single jar, as you had before this specific change.

How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants