Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support go 1.23 #433

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:

strategy:
matrix:
go-version: [ "1.21", "1.22" ]
go-version: [ "1.22", "1.23" ]
runs-on: ubuntu-latest
env:
GOLANGCI_LINT_VERSION: v1.58.0
GOLANGCI_LINT_VERSION: v1.60.1

steps:
- name: Install Go
Expand All @@ -37,7 +37,6 @@ jobs:
uses: golangci/golangci-lint-action@v6
with:
version: ${{ env.GOLANGCI_LINT_VERSION }}
skip-pkg-cache: true

- name: Run tests
run: go test -covermode=count -coverprofile=coverage.out ./...
Expand Down
10 changes: 0 additions & 10 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,8 @@ linters:
enable-all: true
disable:
- cyclop # duplicate of gocyclo
- deadcode # deprecated
- execinquery # deprecated
- exhaustivestruct # deprecated
- golint # deprecated
- gomnd # deprecated
- ifshort # deprecated
- interfacer # deprecated
- maligned # deprecated
- nosnakecase # deprecated
- scopelint # deprecated
- structcheck # deprecated
- varcheck # deprecated
- depguard
- err113
- exhaustive
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ Note that this variable is global, so ideally you'd need to unset it after you'r
## Go Version Support

This library supports the last two versions of Go. While the minimum Go version is
not guarantee to increase along side Go, it may jump from time to time to support
not guaranteed to increase along side Go, it may jump from time to time to support
additional features. This will be not be considered a breaking change.

## Who uses hamba/avro?
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hamba/avro/v2

go 1.20
go 1.21

require (
github.com/ettle/strcase v0.2.0
Expand Down
2 changes: 1 addition & 1 deletion reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func (r *Reader) readBytes(op string) []byte {
if size == 0 {
return []byte{}
}
if max := r.cfg.getMaxByteSliceSize(); max > 0 && size > max {
if maxSize := r.cfg.getMaxByteSliceSize(); maxSize > 0 && size > maxSize {
fnName := "Read" + strings.ToTitle(op)
r.ReportError(fnName, "size is greater than `Config.MaxByteSliceSize`")
return nil
Expand Down
Loading