Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to serialize uint64 values as fixed-length entries: #277

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Ability to serialize uint64 values as fixed-length entries: #277

merged 2 commits into from
Jul 27, 2023

Conversation

joliver
Copy link
Contributor

@joliver joliver commented Jul 27, 2023

This pull request adds the ability to fully express native, uint64 values as fixed-length records within Avro.

See https://stackoverflow.com/a/75242092/151741 for more details.

Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for your use case.

Example usage:

```
type simpleRecord struct { ID uint64 `avro:"id"` }

const simpleRecordSchema = `{
  "type": "record",
  "name": "simple",
  "fields" : [
    {"name": "id", "type": { "name": "uint64", "type": "fixed", "size": 8 } }
  ]
`
```
@joliver
Copy link
Contributor Author

joliver commented Jul 27, 2023

Tests have been added along with an example use case in the most recent commit message.

Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nrwiersma nrwiersma merged commit c7992e2 into hamba:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants