Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow OCF writer to have custom encoder config #266

Merged
merged 1 commit into from
Jun 9, 2023
Merged

feat: allow OCF writer to have custom encoder config #266

merged 1 commit into from
Jun 9, 2023

Conversation

meandnano
Copy link
Contributor

This follows the #265 and allows OCF encoder to have custom value encoder config in contrast with previous behavior of ocf.Ecoder always using avro.DefaultConfig

nrwiersma
nrwiersma approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nrwiersma nrwiersma merged commit cf7abd6 into hamba:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrwiersma nrwiersma nrwiersma approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meandnano @nrwiersma @mikhail-artemev