Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement simple Avro schema validation utility #260

Merged
merged 1 commit into from
Jun 2, 2023
Merged

feat: implement simple Avro schema validation utility #260

merged 1 commit into from
Jun 2, 2023

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Jun 2, 2023

Hi !
First of all, thank you for this library. It is really useful and well designed/implemented. Kudos!

I wanted to contribute back a small command-line utility I developed using this library that turned out very useful for us. The tool allows to validate Avro schemas, i.e. check that they are well-formed/parseable. We use this tool mostly in our CI/CD pipelines as an extra layer of protection to schema syntax mistakes/breaking.

I based the code pretty much on the existing avrogen utility code for consistency and also added unit tests.
Note that I had to manually clear the global schemas cache after each subtest in TestAvroSv_ValidatesSchema, otherwise a previous subtest state influences the next one.

Given that I was there, I also fixed an existing minor typo in the README (./app instead of avrogen).

I hope you are okay with this contribution, if you prefer not to accept it, no hard feelings!

@nrwiersma
Copy link
Member

Thanks for the contribution 🎉 This seems like a simple but valuable addition.

Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrwiersma nrwiersma merged commit 0f17b28 into hamba:main Jun 2, 2023
@hhromic hhromic deleted the avrosv branch June 2, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants