Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and improvements #57

Open
wants to merge 10 commits into
base: 1.7.10
Choose a base branch
from
Open

Conversation

kmecpp
Copy link
Collaborator

@kmecpp kmecpp commented Sep 20, 2018

I will do more work on Quantum Assemblers but didn't have time to fix all the issues with BlockPos, which wasn't being loaded on readFromNBT.

To fix combining turbines and and some other issues, I stopped it from being cached in BaseTile. However, when you login, the packets don't send immediately. I wasn't sure how else to fix that so I lowered the packet transfer update rate in TileElectricTurbine. it looks better but I feel like there should be a better fix.

Water still doesn't boil though and I'm not sure why

@halvors
Copy link
Owner

halvors commented Sep 24, 2018

@kmecpp Thanks for your contribution, there's only one problem. Nuclear Physics does all change to 1.10.2 branch, and backports those changes to 1.7.10. For 1.7.10 specific issues it should be changed on the 1.7.10 branch, but for general fixes and changes those should be made on the 1.10.2 branch.

There's many great changes and fixes here, very good work :) But for the reasons mentioned above, i'd have to apply this PR manually on the 1.10 branch, and the 1.7 specific on the 1.7 branch.

I'll do this when i have some spare time, i'll of course give you credit :)

But keep in mind for next time, try to target 1.10 branch when sending pull request, if it's not 1.7.10 specific code.
The fixing of BlockPos thing is surely something to target 1.7.10 for :)

Thank you very much, i'll consider giving you access directly to this GIT respository at a later time.

@halvors halvors self-assigned this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants