Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support querying sub-categories of any level #2995

Merged
merged 9 commits into from
Dec 22, 2022
Merged

Support querying sub-categories of any level #2995

merged 9 commits into from
Dec 22, 2022

Conversation

chengfeiyue
Copy link
Contributor

@chengfeiyue chengfeiyue commented Dec 18, 2022

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

添加一个方法可以根据分类树的任意一层级的名称查询子树

Which issue(s) this PR fixes:

Fixes #2960

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

CategoryFinder 添加根据分类查询子分类树结构的方法

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 19, 2022

/cc @halo-dev/sig-halo

@ruibaby
Copy link
Member

ruibaby commented Dec 21, 2022

/retitle feat: add listAsTree(name) method for category finder

@f2c-ci-robot f2c-ci-robot bot changed the title Add a method listSubTreeByName feat: add listAsTree(name) method for category finder Dec 21, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 21, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@JohnNiang JohnNiang changed the title feat: add listAsTree(name) method for category finder Support querying sub-categories of any level Dec 21, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnNiang,guqing,ruibaby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit a7da2c0 into halo-dev:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CategoryFinder 需要提供根据一个分类查询其下子分类树状结构的方法
5 participants