Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add author pages for theme-side #2923

Merged
merged 10 commits into from
Dec 14, 2022
Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 12, 2022

What type of PR is this?

/kind feature
/area core

What this PR does / why we need it:

为主题端新增作者页面
see #2837 for more detail

Which issue(s) this PR fixes:

Fixes #2837

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

主题端支持作者页面

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Dec 12, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 12, 2022

我将尝试在 https://github.com/halo-dev/theme-earth 实现这个模板。

@guqing
Copy link
Member Author

guqing commented Dec 12, 2022

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 13, 2022

theme-earth 已经适配:halo-dev/theme-earth#23

可以使用 earth-author.zip 进行测试。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

需要在 2.1.x 发布时,补充开发者文档:halo-dev/docs#143

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@guqing
Copy link
Member Author

guqing commented Dec 13, 2022

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang
Copy link
Member

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 7a2f5d0 into halo-dev:main Dec 14, 2022
@guqing guqing deleted the feature/2837 branch December 14, 2022 09:40
f2c-ci-robot bot pushed a commit to halo-dev/theme-earth that referenced this pull request Dec 15, 2022
添加作者页面,并将之前部分展示作者名称和头像的位置添加了作者访问链接。适配:halo-dev/halo#2923

<img width="1920" alt="image" src="https://user-images.githubusercontent.com/21301288/207251573-cff9135c-6e0d-4af1-8db1-43bcfbbe2071.png">
<img width="1920" alt="image" src="https://user-images.githubusercontent.com/21301288/207251627-69def72d-1f8f-4b78-b743-e2faddb71837.png">

/kind feature

```release-note
添加作者模板,支持根据作者归档文章。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望为主题端添加作者页面
3 participants