Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that MySQL complains "Data too long for column 'data' at row 1" #2833

Merged

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Dec 5, 2022

What type of PR is this?

/kind improvement
/area core
/milestone 2.0.1

What this PR does / why we need it:

See #2832 and #2832 (comment) for more.

For a workaround, please refer to:

But, there are still limitations here:

  • For MySQL: ~4GB
  • For PosgreSQL: ~1GB

Which issue(s) this PR fixes:

Fixes #2832

Does this PR introduce a user-facing change?

修复因文章过长导致无法保存数据的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0.1 milestone Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Dec 5, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 5980b5b into halo-dev:main Dec 5, 2022
@JohnNiang JohnNiang deleted the refactor/modify-data-type-for-mysql branch December 7, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章内容很长时无法保存
3 participants