Handle exception while sending test email #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/cc @halo-dev/sig-halo |
JohnNiang
requested changes
Apr 19, 2022
src/main/java/run/halo/app/controller/admin/api/MailController.java
Outdated
Show resolved
Hide resolved
|
/kind bug |
JohnNiang
requested changes
Apr 19, 2022
JohnNiang
requested changes
Apr 19, 2022
|
已经在ControllerWxceptionHandler进行异常处理了。 |
JohnNiang
reviewed
Apr 19, 2022
src/main/java/run/halo/app/core/ControllerExceptionHandler.java
Outdated
Show resolved
Hide resolved
ruibaby
requested changes
Apr 19, 2022
src/main/java/run/halo/app/core/ControllerExceptionHandler.java
Outdated
Show resolved
Hide resolved
|
/retitle Handle exception while sending test email |
f2c-ci-robot
bot
changed the title
JohnNiang
reviewed
Apr 20, 2022
f2c-ci-robot
bot
added
the
approved
JohnNiang
approved these changes
Apr 20, 2022
ruibaby
approved these changes
Apr 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1858
What this PR does?