Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPE when deleting category #1806

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 1, 2022

What this PR does?

修复删除分类时的NPE问题,导致原因是1.5.1事件发布时加了参数,测试类没有覆盖到。

Why we need it?

Fix #1805

/cc @halo-dev/sig-halo
/area core
/kind bug

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 32f2462 into halo-dev:master Apr 1, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Apr 8, 2022
@guqing guqing deleted the bugfix/category-remove branch April 15, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

删除分类出现空指针异常
2 participants