feat: MarkDown supports footnote rendering #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guqing
added
the
kind/feature
Closed
|
Please fix ci check first. |
ok, later on |
|
可以审查了 适配markdown-it-footnote已解决 |
JohnNiang
requested changes
Jun 27, 2021
src/test/java/run/halo/app/utils/FootnoteNodeRendererInterceptorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/run/halo/app/utils/FootnoteNodeRendererInterceptorTest.java
Outdated
Show resolved
Hide resolved
|
https://github.com/halo-dev/halo-editor 编辑器已经支持，你可以用来对比一下渲染后的效果。@guqing |
ruibaby
requested changes
Jun 27, 2021
ruibaby
approved these changes
Jun 27, 2021
|
LGTM |
JohnNiang
reviewed
Jun 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates footnote references in the document. Footnotes are placed at the bottom of the rendered document with links from footnote references to footnote.