Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

归档页面数据，未按月份倒序 #2958

Closed
liaocp666 opened this issue Dec 15, 2022 · 6 comments · Fixed by #2959
Closed

归档页面数据，未按月份倒序 #2958

liaocp666 opened this issue Dec 15, 2022 · 6 comments · Fixed by #2959
Assignees
@liaocp666
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.1.0

Comments

@liaocp666
Copy link
Contributor

是什么版本出现了此问题？

2.0.1

使用的什么数据库？

H2

使用的哪种方式部署？

Docker

在线站点地址

No response

发生了什么？

访问 /archives 地址，目前月份数据升序返回。此处建议月份降序返回。

因为年份是降序，月份升序，月份里的文章是降序。有点错乱。同时如果月份数据降序，对于主题制作时间轴等效果更加友好。

相关日志输出

No response

附加信息

No response
@liaocp666 liaocp666 mentioned this issue Dec 15, 2022
Merged
@minliacom
Copy link
Contributor

是说要所有都降序吗年月日？

@ruibaby
Copy link
Member

ruibaby commented Dec 15, 2022

是说要所有都降序吗年月日？

理论上是的。最新的排前面。

@ruibaby
Copy link
Member

ruibaby commented Dec 15, 2022

/kind improvement
/area console
/milestone 2.1.x

/assign @liaocp666

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Dec 15, 2022
f2c-ci-robot bot pushed a commit that referenced this issue Dec 16, 2022
@liaocp666
feat: archives in descending order by month (#2959)
2a9a394 
<!--  Thanks for sending a pull request!  Here are some tips for you:
1. 如果这是你的第一次，请阅读我们的贡献指南：<https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>。
1. If this is your first time, please read our contributor guidelines: <https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>.
2. 请根据你解决问题的类型为 Pull Request 添加合适的标签。
2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.
3. 请确保你已经添加并运行了适当的测试。
3. Ensure you have added or ran the appropriate tests for your PR.
-->

#### What type of PR is this?
/kind improvement
<!--
添加其中一个类别：
Add one of the following kinds:

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind improvement

适当添加其中一个或多个类别（可选）：
Optionally add one or more of the following kinds if applicable:

/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->

#### What this PR does / why we need it:

优化归档页面数据排序，按月份降序

#### Which issue(s) this PR fixes:

<!--
PR 合并时自动关闭 issue。
Automatically closes linked issue when PR is merged.

用法：`Fixes #<issue 号>`，或者 `Fixes (粘贴 issue 完整链接)`
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #2958 

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo

#### Does this PR introduce a user-facing change?

<!--
如果当前 Pull Request 的修改不会造成用户侧的任何变更，在 `release-note` 代码块儿中填写 `NONE`。
否则请填写用户侧能够理解的 Release Note。如果当前 Pull Request 包含破坏性更新（Break Change），
Release Note 需要以 `action required` 开头。
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->

```release-note
归档数据按月降序
```
@JohnNiang
Copy link
Member

JohnNiang commented Dec 16, 2022 •
edited
Loading

我的理解：这应该算是一个 bug 吧，并且应该在 2.0.x 也修复掉。 @halo-dev/sig-halo

@ruibaby
Copy link
Member

ruibaby commented Dec 16, 2022

我的理解：这应该算是一个 bug 吧，并且应该在 2.0.x 也修复掉。 @halo-dev/sig-halo

可以。

@JohnNiang
Copy link
Member

/remove-kind improvement
/remove-area console
/kind bug
/area core

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core and removed kind/improvement Categorizes issue or PR as related to a improvement. area/console Issues or PRs related to the Halo Console labels Dec 16, 2022
@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liaocp666 liaocp666

Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

feat: archives in descending order by month
4 participants
@minliacom @JohnNiang @ruibaby @liaocp666