This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: asynchronously load the default editor #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Vue 3 异步组件的文档：https://cn.vuejs.org/guide/components/async.html |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 默认编辑器改为异步的形式加载。 优化前后对比： 优化前编译： <img width="480" alt="image" src="https://user-images.githubusercontent.com/21301288/209529091-07216f42-8668-46fc-80e6-03db5504e576.png"> 优化后编译： <img width="510" alt="image" src="https://user-images.githubusercontent.com/21301288/209529001-31537104-cada-4e3c-b521-8849b53281ce.png"> 优化前首次加载： <img width="1069" alt="image" src="https://user-images.githubusercontent.com/21301288/209529285-a62cfe92-5aa0-47f6-ad7e-9f0210ca97b6.png"> 优化后首次加载： <img width="1067" alt="image" src="https://user-images.githubusercontent.com/21301288/209529349-24aa99b9-5b52-4d44-8144-60028332e9cd.png"> 最终会在打开文章编辑页面的时候加载编辑器资源：  > 这个 Gif 的演示做了节流处理来模拟服务器带宽的情况。在带宽不良的情况下会显示加载动画以提示使用者正在加载编辑器。 #### Which issue(s) this PR fixes: Fixes halo-dev#3047 #### Special notes for your reviewer: 测试方式： 1. 插件默认编辑器是否正常加载以及功能是否正常即可。 #### Does this PR introduce a user-facing change? ```release-note Console 端的默认编辑器改为异步加载，优化整体的加载性能。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
默认编辑器改为异步的形式加载。
优化前后对比：
优化前编译：
优化后编译：
优化前首次加载：
优化后首次加载：
最终会在打开文章编辑页面的时候加载编辑器资源：
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3047
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?