Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: add more operation feedback prompt #785

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 20, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

为部分关键操作添加反馈提示。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2979

Special notes for your reviewer:

测试方式:

  1. 测试 Console 端所有页面的操作。
  2. 观察是否有反馈。

Does this PR introduce a user-facing change?

完善 Console 端的部分操作反馈提示

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 20, 2022
@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 9:04AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice work!

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit ca47494 into halo-dev:main Dec 20, 2022
@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 25, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

为部分关键操作添加反馈提示。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2979

#### Special notes for your reviewer:

测试方式:

1. 测试 Console 端所有页面的操作。
2. 观察是否有反馈。

#### Does this PR introduce a user-facing change?

```release-note
完善 Console 端的部分操作反馈提示
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为 Console 端的部分操作提供提示反馈
3 participants