Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: optimize the layout of some forms on mobile #564

Merged
merged 1 commit into from
May 9, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 9, 2022

before:

image

image

after:

image

image

/kind feature
/milestone 1.5.x
/cc @halo-dev/sig-halo-admin

fixes halo-dev/halo#1919

Signed-off-by: Ryan Wang [email protected]

@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG May 9, 2022 04:04
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone May 9, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ruibaby after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4ebdce5 into halo-dev:master May 9, 2022
@JohnNiang
Copy link
Member

/cherrypick release-1.5

@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #565

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby deleted the perf/form-mobile-layout branch October 9, 2022 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章设置弹窗表单移动端布局异常
4 participants