Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: no processing bar for page jumps longer than 250ms #539

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 6, 2022

修复加载页面(跳转路由)时长超过 250 ms 的时候,不显示加载动画的问题。

Signed-off-by: Ryan Wang [email protected]

@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG April 6, 2022 09:52
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu April 6, 2022 09:52
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Apr 6, 2022

/kind bug
/cc @halo-dev/sig-halo-admin

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QuentinHsu, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 5ed960f into halo-dev:master Apr 6, 2022
@ruibaby ruibaby deleted the fix/before-router-not-show-progress-bar branch April 6, 2022 13:52
@ruibaby ruibaby added this to the 1.5.x milestone Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants