Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: no category in category management does not show empty tips #538

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 6, 2022

before:

image

after:

image

/kind bug
/cc @halo-dev/sig-halo-admin

Signed-off-by: Ryan Wang [email protected]

@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG April 6, 2022 07:49
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 6, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Apr 6, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 30f3349 into halo-dev:master Apr 6, 2022
@ruibaby ruibaby deleted the fix/category-list-empty branch April 7, 2022 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants